Fix SearchApplication misusing BytesStreamOutput #127957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing an xcontent builder in general also closes the underlying stream. The only reason this worked was that we were always using the no-pooling `BigArrays` which also makes the use of the circuit breaker a noop here. Found this when trying to optimize the releasable bytes stream and seeing it break. => just move the non-pooled bytes stream to simplify things
original-brownbear
added
>non-issue
:EnterpriseSearch/Application
Contributor
Author
|
npnp thanks Carlos! |
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Closing an xcontent builder in general also closes the underlying stream. The only reason this worked was that we were always using the no-pooling `BigArrays` which also makes the use of the circuit breaker a noop here. Found this when trying to optimize the releasable bytes stream and seeing it break. => just move the non-pooled bytes stream to simplify things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing an xcontent builder in general also closes the underlying stream. The only reason this worked was that we were always using the no-pooling
BigArrayswhich also makes the use of the circuit breaker a noop here. Found this when trying to optimize the releasable bytes stream and seeing it break.=> just move the non-pooled bytes stream to simplify things